{"id":629,"date":"2020-06-17T10:36:06","date_gmt":"2020-06-17T10:36:06","guid":{"rendered":"http:\/\/pragmaticways.com\/?p=629"},"modified":"2021-01-26T05:48:03","modified_gmt":"2021-01-26T05:48:03","slug":"refactoring-a-speeding-ticket","status":"publish","type":"post","link":"https:\/\/pragmaticways.com\/refactoring-a-speeding-ticket\/","title":{"rendered":"Refactoring a speeding ticket"},"content":{"rendered":"\n<p>In this article we go through some more refactoring techniques to write cleaner code with this homework submissions.  <\/p>\n\n\n\n<p>(If you want to submit some code to get refactored through a video, then join the Software Engineering Mastermind Group on facebook! <a href=\"https:\/\/www.facebook.com\/groups\/SoftwareEngineeringMastermindGroup\" class=\"rank-math-link\">https:\/\/www.facebook.com\/groups\/SoftwareEngineeringMastermindGroup<\/a>)  <\/p>\n\n\n\n<div class=\"wp-block-group has-very-light-gray-background-color has-background\"><div class=\"wp-block-group__inner-container\">\n<p><strong>Here are the instructions for this assignment: <\/strong><br>You are driving a little too fast, and a police officer stops you. <br>Write a method to compute the result: <\/p>\n\n\n\n<ul><li>0 = no ticket <\/li><li>1 = small ticket <\/li><li>2 = big ticket   <\/li><\/ul>\n\n\n\n<p>If speed is 60 or less, the result is 0. <br>If speed is between 61 and 80 inclusive, the result is 1. <br>If speed is 81 or more, the result is 2. <br>Unless it is your birthday, on that day, your speed can be 5 higher in all cases.   <\/p>\n\n\n\n<p><strong>Test Cases<\/strong><br>caughtSpeeding(60, false) \u2192 0 <br>caughtSpeeding(65, false) \u2192 1 <br>caughtSpeeding(65, true) \u2192 0<\/p>\n<\/div><\/div>\n\n\n\n<div style=\"height:60px\" aria-hidden=\"true\" class=\"wp-block-spacer\"><\/div>\n\n\n\n<p><strong>Did you know?<\/strong><br>There&#8217;s an entire book on refactoring that you MUST read if you want to <em>really<\/em> get good at refactoring code. <\/p>\n\n\n\n<iframe style=\"width:120px;height:240px;\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\" frameborder=\"0\" src=\"\/\/ws-na.amazon-adsystem.com\/widgets\/q?ServiceVersion=20070822&amp;OneJS=1&amp;Operation=GetAdHtml&amp;MarketPlace=US&amp;source=ac&amp;ref=tf_til&amp;ad_type=product_link&amp;tracking_id=selftaughtadu-20&amp;marketplace=amazon&amp;region=US&amp;placement=0134757599&amp;asins=0134757599&amp;linkId=2a02158b7e9ba8bb8492b4789b54e723&amp;show_border=true&amp;link_opens_in_new_window=true&amp;price_color=333333&amp;title_color=0066c0&amp;bg_color=ffffff\">\n    <\/iframe>\n\n\n\n<div style=\"height:99px\" aria-hidden=\"true\" class=\"wp-block-spacer\"><\/div>\n\n\n\n<p><strong>Care to watch instead of read it?<\/strong><br>Scroll down to <a href=\"#video\" class=\"rank-math-link\">the bottom of this page <\/a>to watch the video!<\/p>\n\n\n\n<div style=\"height:60px\" aria-hidden=\"true\" class=\"wp-block-spacer\"><\/div>\n\n\n\n<h2>The Original Submission<\/h2>\n\n\n<pre class=\"wp-block-code\" aria-describedby=\"shcb-language-1\" data-shcb-language-name=\"JavaScript\" data-shcb-language-slug=\"javascript\"><div><code lang=\"java\" class=\"hljs language-javascript language-java\">public <span class=\"hljs-keyword\">static<\/span> <span class=\"hljs-keyword\">void<\/span> main(<span class=\"hljs-built_in\">String<\/span>[] args) {\n   caughtSpeeding (<span class=\"hljs-number\">60<\/span>,<span class=\"hljs-literal\">false<\/span>);\n   caughtSpeeding (<span class=\"hljs-number\">65<\/span>,<span class=\"hljs-literal\">false<\/span>);\n   caughtSpeeding (<span class=\"hljs-number\">65<\/span>,<span class=\"hljs-literal\">true<\/span>);\n }\n public <span class=\"hljs-keyword\">static<\/span> <span class=\"hljs-keyword\">void<\/span> caughtSpeeding (int speed, boolean isBirthday) {\n <span class=\"hljs-keyword\">if<\/span> (isBirthday) {\n     <span class=\"hljs-keyword\">if<\/span>(speed&lt;=<span class=\"hljs-number\">65<\/span>) {       \n      System.out.println(<span class=\"hljs-number\">0<\/span>);     \n     }<span class=\"hljs-keyword\">else<\/span> <span class=\"hljs-keyword\">if<\/span> (speed&gt;=<span class=\"hljs-number\">66<\/span> &amp;&amp; speed&lt;=<span class=\"hljs-number\">85<\/span>) {       \n      System.out.println(<span class=\"hljs-number\">1<\/span>);     \n     }<span class=\"hljs-keyword\">else<\/span> <span class=\"hljs-keyword\">if<\/span> (speed&gt;=<span class=\"hljs-number\">86<\/span>) {\n       System.out.println(<span class=\"hljs-number\">2<\/span>);\n     }\n   }<span class=\"hljs-keyword\">else<\/span> {\n     <span class=\"hljs-keyword\">if<\/span>(speed&lt;=<span class=\"hljs-number\">60<\/span>) {       \n       System.out.println(<span class=\"hljs-number\">0<\/span>);     \n    }<span class=\"hljs-keyword\">else<\/span> <span class=\"hljs-keyword\">if<\/span> (speed&gt;=<span class=\"hljs-number\">61<\/span> &amp;&amp; speed &lt;=<span class=\"hljs-number\">88<\/span>) {       \n      System.out.println(<span class=\"hljs-number\">1<\/span>);     \n    }<span class=\"hljs-keyword\">else<\/span> <span class=\"hljs-keyword\">if<\/span>(speed&gt;=<span class=\"hljs-number\">81<\/span>) {\n       System.out.println(<span class=\"hljs-number\">2<\/span>);\n     }\n   }\n }<\/code><\/div><small class=\"shcb-language\" id=\"shcb-language-1\"><span class=\"shcb-language__label\">Code language:<\/span> <span class=\"shcb-language__name\">JavaScript<\/span> <span class=\"shcb-language__paren\">(<\/span><span class=\"shcb-language__slug\">javascript<\/span><span class=\"shcb-language__paren\">)<\/span><\/small><\/pre>\n\n\n<h2>The Refactored Code<\/h2>\n\n\n<pre class=\"wp-block-code\" aria-describedby=\"shcb-language-2\" data-shcb-language-name=\"PHP\" data-shcb-language-slug=\"php\"><div><code lang=\"java\" class=\"hljs language-php language-java\"><span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">static<\/span> void main(String[] args) {\n  int useCase1 = caughtSpeeding(<span class=\"hljs-number\">60<\/span>, <span class=\"hljs-keyword\">false<\/span>);\n  int useCase2 = caughtSpeeding(<span class=\"hljs-number\">65<\/span>, <span class=\"hljs-keyword\">false<\/span>);\n  int useCase3 = caughtSpeeding(<span class=\"hljs-number\">65<\/span>, <span class=\"hljs-keyword\">true<\/span>);\n\n  System.out.println(useCase1);\n  System.out.println(useCase2);\n  System.out.println(useCase3);\n}\n\n<span class=\"hljs-keyword\">private<\/span> <span class=\"hljs-keyword\">static<\/span> int caughtSpeeding(int speed, boolean isBirthday) {\n  TicketCalculator ticket;\n  <span class=\"hljs-keyword\">if<\/span> (isBirthday) {\n    ticket = <span class=\"hljs-keyword\">new<\/span> TicketCalculatorOnBirthday();\n  } <span class=\"hljs-keyword\">else<\/span> {\n    ticket = <span class=\"hljs-keyword\">new<\/span> TicketCalculator();\n  }\n  <span class=\"hljs-keyword\">return<\/span> ticket.getTicket(speed);\n}\n \n<span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">static<\/span> <span class=\"hljs-class\"><span class=\"hljs-keyword\">class<\/span> <span class=\"hljs-title\">TicketCalculator<\/span> <\/span>{\n  <span class=\"hljs-keyword\">protected<\/span> int NO_TICKET_MAX_SPEED = <span class=\"hljs-number\">60<\/span>;\n  <span class=\"hljs-keyword\">protected<\/span> int SMALL_TICKET_MIN_SPEED = <span class=\"hljs-number\">61<\/span>;\n  <span class=\"hljs-keyword\">protected<\/span> int SMALL_TICKET_MAX_SPEED = <span class=\"hljs-number\">80<\/span>;\n  <span class=\"hljs-keyword\">protected<\/span> int BIG_TICKET_MIN_SPEED = <span class=\"hljs-number\">81<\/span>;\n\n  <span class=\"hljs-keyword\">public<\/span> int getTicket(int speed) {\n    <span class=\"hljs-keyword\">if<\/span> (isNoTicket(speed)) {\n      <span class=\"hljs-keyword\">return<\/span> Ticket.NO_TICKET;\n    } <span class=\"hljs-keyword\">else<\/span> <span class=\"hljs-keyword\">if<\/span> (isSmallTicket(speed)) {\n      <span class=\"hljs-keyword\">return<\/span> Ticket.SMALL_TICKET;\n    } <span class=\"hljs-keyword\">else<\/span> <span class=\"hljs-keyword\">if<\/span> (isBigTicket(speed)) {\n      <span class=\"hljs-keyword\">return<\/span> Ticket.BIG_TICKET;\n    } <span class=\"hljs-keyword\">else<\/span> {\n      <span class=\"hljs-keyword\">return<\/span> Ticket.ERROR_CODE;\n    }\n  }\n\n  <span class=\"hljs-keyword\">private<\/span> boolean isNoTicket(int speed) {\n    <span class=\"hljs-keyword\">return<\/span> speed &lt;= NO_TICKET_MAX_SPEED; \n  }\n\n  <span class=\"hljs-keyword\">private<\/span> boolean isSmallTicket(int speed) {\n    <span class=\"hljs-keyword\">return<\/span> speed &gt;= SMALL_TICKET_MIN_SPEED &amp;&amp; speed &lt;= SMALL_TICKET_MAX_SPEED;\n  }\n\n  <span class=\"hljs-keyword\">private<\/span> boolean isBigTicket(int speed) {\n    <span class=\"hljs-keyword\">return<\/span> speed &gt;= BIG_TICKET_MIN_SPEED;\n  }\n} \n\n<span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">static<\/span> <span class=\"hljs-class\"><span class=\"hljs-keyword\">class<\/span> <span class=\"hljs-title\">TicketCalculatorOnBirthday<\/span> <span class=\"hljs-keyword\">extends<\/span> <span class=\"hljs-title\">TicketCalculator<\/span> <\/span>{\n  <span class=\"hljs-keyword\">public<\/span> TicketCalculatorOnBirthday() {\n    super();\n    adjustSpeedLimitsForBirthday();\n  }\n\n  <span class=\"hljs-keyword\">private<\/span> void adjustSpeedLimitsForBirthday() {\n    int adjustSpeedBy = <span class=\"hljs-number\">5<\/span>;\n\n    NO_TICKET_MAX_SPEED += adjustSpeedBy;\n    SMALL_TICKET_MIN_SPEED += adjustSpeedBy;\n    SMALL_TICKET_MAX_SPEED += adjustSpeedBy;\n    BIG_TICKET_MIN_SPEED += adjustSpeedBy;\n   }\n}\n\n<span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-class\"><span class=\"hljs-keyword\">class<\/span> <span class=\"hljs-title\">Ticket<\/span> <\/span>{\n  <span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">final<\/span> <span class=\"hljs-keyword\">static<\/span> int NO_TICKET = <span class=\"hljs-number\">0<\/span>;\n  <span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">final<\/span> <span class=\"hljs-keyword\">static<\/span> int SMALL_TICKET = <span class=\"hljs-number\">1<\/span>;\n  <span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">final<\/span> <span class=\"hljs-keyword\">static<\/span> int BIG_TICKET = <span class=\"hljs-number\">2<\/span>;\n  <span class=\"hljs-keyword\">public<\/span> <span class=\"hljs-keyword\">final<\/span> <span class=\"hljs-keyword\">static<\/span> int ERROR_CODE = <span class=\"hljs-number\">-1<\/span>;\n}<\/code><\/div><small class=\"shcb-language\" id=\"shcb-language-2\"><span class=\"shcb-language__label\">Code language:<\/span> <span class=\"shcb-language__name\">PHP<\/span> <span class=\"shcb-language__paren\">(<\/span><span class=\"shcb-language__slug\">php<\/span><span class=\"shcb-language__paren\">)<\/span><\/small><\/pre>\n\n\n<div style=\"height:44px\" aria-hidden=\"true\" class=\"wp-block-spacer\"><\/div>\n\n\n\n<iframe id=\"video\" width=\"560\" height=\"315\" src=\"https:\/\/www.youtube.com\/embed\/u4Dc_Pzl-50\" frameborder=\"0\" allow=\"accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture\" allowfullscreen=\"\"><\/iframe>\n\n\n\n<div style=\"height:20px\" aria-hidden=\"true\" class=\"wp-block-spacer\"><\/div>\n\n\n\n<iframe style=\"width:120px;height:240px;\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\" frameborder=\"0\" src=\"\/\/ws-na.amazon-adsystem.com\/widgets\/q?ServiceVersion=20070822&amp;OneJS=1&amp;Operation=GetAdHtml&amp;MarketPlace=US&amp;source=ac&amp;ref=tf_til&amp;ad_type=product_link&amp;tracking_id=selftaughtadu-20&amp;marketplace=amazon&amp;region=US&amp;placement=0134757599&amp;asins=0134757599&amp;linkId=2a02158b7e9ba8bb8492b4789b54e723&amp;show_border=true&amp;link_opens_in_new_window=true&amp;price_color=333333&amp;title_color=0066c0&amp;bg_color=ffffff\"><\/iframe>\n    \n<iframe style=\"width:120px;height:240px;\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\" frameborder=\"0\" src=\"\/\/ws-na.amazon-adsystem.com\/widgets\/q?ServiceVersion=20070822&amp;OneJS=1&amp;Operation=GetAdHtml&amp;MarketPlace=US&amp;source=ac&amp;ref=tf_til&amp;ad_type=product_link&amp;tracking_id=selftaughtadu-20&amp;marketplace=amazon&amp;region=US&amp;placement=B00666M59G&amp;asins=B00666M59G&amp;linkId=e01af1e5ac688eff83e19c0cac851ce4&amp;show_border=true&amp;link_opens_in_new_window=true&amp;price_color=333333&amp;title_color=0066c0&amp;bg_color=ffffff\">\n    <\/iframe>\n\n\n<iframe style=\"width:120px;height:240px;\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\" frameborder=\"0\" src=\"\/\/ws-na.amazon-adsystem.com\/widgets\/q?ServiceVersion=20070822&amp;OneJS=1&amp;Operation=GetAdHtml&amp;MarketPlace=US&amp;source=ac&amp;ref=tf_til&amp;ad_type=product_link&amp;tracking_id=selftaughtadu-20&amp;marketplace=amazon&amp;region=US&amp;placement=0596007124&amp;asins=0596007124&amp;linkId=154cfe26ed99be84aa35926754ea977a&amp;show_border=true&amp;link_opens_in_new_window=true&amp;price_color=333333&amp;title_color=0066c0&amp;bg_color=ffffff\">\n    <\/iframe>\n","protected":false},"excerpt":{"rendered":"<p>In this article we go through some more refactoring techniques to write cleaner code with this homework submissions. (If you want to submit some code to get refactored through a<\/p>\n","protected":false},"author":1,"featured_media":688,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":[],"categories":[42,33],"tags":[],"_links":{"self":[{"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/posts\/629"}],"collection":[{"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/comments?post=629"}],"version-history":[{"count":0,"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/posts\/629\/revisions"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/media\/688"}],"wp:attachment":[{"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/media?parent=629"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/categories?post=629"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/pragmaticways.com\/wp-json\/wp\/v2\/tags?post=629"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}